Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy pasting Body instance #3326

Open
kof opened this issue May 7, 2024 · 6 comments
Open

Copy pasting Body instance #3326

kof opened this issue May 7, 2024 · 6 comments
Labels
area:components Parametrized code components complexity:medium Up to 1 week of work prio:2 Always look for prio:1 issues first before working on prio:2 type:feat Features and enhancements

Comments

@kof
Copy link
Member

kof commented May 7, 2024

As a user I want to be able to copy/paste the entire body contents, because usually people put instances inside the body, not an extra box for copy pasting.

Problem has been so far that we don't know how to merge 2 bodies and there can be only one in the end.

Solution: ask the user in a dialog: Do you want to use the new body or keep current one? [new] [current][abort]

Now when user selects new one, we are overriding. If user picks the old one - we are inserting the contents of the new body inside the old body.

@kof kof added area:components Parametrized code components type:feat Features and enhancements complexity:medium Up to 1 week of work prio:2 Always look for prio:1 issues first before working on prio:2 labels May 7, 2024
@kof
Copy link
Member Author

kof commented May 7, 2024

Alternatively when copying body, we just copy the contents of the body and show toast (copied body contents, because body can not be copied)

Then there is no need for confirmation dialog and its all much simpler

@johnsicili
Copy link
Contributor

Easier approach for sure and better than what is there. Downside is vars won't copy over and I place my vars almost exclusively on the body. Still would rather have any of these options above than none.

@TrySound
Copy link
Member

TrySound commented May 8, 2024

alternatively we could copy whole page along with body

@kof
Copy link
Member Author

kof commented May 8, 2024

alternatively we could copy whole page along with body

We will need this in any case. The problem with copying body is that it feels very natural to copy the root node and paste it somewhere else.

Its super unnatural to have to create a Box inside body just so one can copy the entire thing.

People will always intuitively go create a page first, then go to some template and try copy the body.

@TrySound
Copy link
Member

TrySound commented May 8, 2024

We will need this in any case. The problem with copying body is that it feels very natural to copy the root node and paste it somewhere else.

it is also unnatural when paste deletes something

@kof
Copy link
Member Author

kof commented May 8, 2024

it is also unnatural when paste deletes something

Yes, we won't be deleting anything unless user explicitely agrees

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:components Parametrized code components complexity:medium Up to 1 week of work prio:2 Always look for prio:1 issues first before working on prio:2 type:feat Features and enhancements
Projects
None yet
Development

No branches or pull requests

3 participants