Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate dot in the property name #3573

Closed
kof opened this issue Jun 15, 2024 · 2 comments · Fixed by #4216
Closed

Validate dot in the property name #3573

kof opened this issue Jun 15, 2024 · 2 comments · Fixed by #4216
Assignees
@istarkov
Labels
area:cli Webstudio CLI complexity:low Good for newcomers, up to a few days of work prio:2 Always look for prio:1 issues first before working on prio:2 type:bug Something isn't working

Comments

@kof
Copy link
Member

kof commented Jun 15, 2024

A user used "x-on:click.prevent" and it broke jsx compiler because it doesn't support it. Now the only way to compile to jsx is to use object spread.
@kof kof added type:bug Something isn't working complexity:low Good for newcomers, up to a few days of work area:cli Webstudio CLI prio:1 The most important thing to work on labels Jun 15, 2024
@TrySound
Copy link
Member

TrySound commented Jun 15, 2024 •
edited
Loading

Dots should be validated away in ui. We cant support other feameworks yet

@kof
Copy link
Member Author

kof commented Jun 15, 2024

Turns out dot is invalid in attributes in HTML5, so we will not support it too. What we need is to validate it and not let it through.

@kof kof changed the title Support dot in the property name Validate dot in the property name Jun 20, 2024
@kof kof added prio:2 Always look for prio:1 issues first before working on prio:2 and removed prio:1 The most important thing to work on labels Oct 2, 2024
@istarkov istarkov mentioned this issue Oct 4, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@istarkov istarkov

Labels
area:cli Webstudio CLI complexity:low Good for newcomers, up to a few days of work prio:2 Always look for prio:1 issues first before working on prio:2 type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Skip unsafe attribute names on generation webstudio-is/webstudio
3 participants
@kof @istarkov @TrySound