[Windows] Fix PHP 8+ compatibility #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thank you! merged. It fails the github actions, but that's due time-ing out, it works OK in my docker test images. |
nono303
pushed a commit
to nono303/win-build-scripts
that referenced
this pull request
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use stdint.h for PHP 8.0, 8.1, 8.2 et cetera. Otherwise keep using win32/php_stdint,h
Added some indentation to clarify the if/else/endif construction
_MSC_VER 1920 = Visual Studio 2019 version 16.0.0 or VS16, which is used for PHP8 on Windows.