Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security concern #9

Closed
challet opened this issue Jan 5, 2011 · 1 comment
Closed

security concern #9

challet opened this issue Jan 5, 2011 · 1 comment

Comments

@challet
Copy link

challet commented Jan 5, 2011

are you sure setting a default password value is a good idea ? https://github.com/webtechnick/CakePHP-Facebook-Plugin/blob/master/controllers/components/connect.php#L108

Let study the following case :

  • i log-in with facebook. my account password has now the "disabled" value (actually it is not disabled, just having this value)
  • sometimes on the web site, i can change/add my email address
  • this website has kept the CakePHP Auth login system enabled (because not everyone wants to log with facebook)
  • someone (for instance a facebook "friend") knows my email address and that i logged on the website
  • he just have to go to the website and enters my email address as the login and "disabled" as the password
  • he got my identity on the website

I haven't tested it now, i'll keep you in touch when this is done.

@webtechnick
Copy link
Owner

Indeed you are correct. The idea originally behind it was if you're letting the user login as a facebook user you shouldn't allow the user to login as a normal user. This wasn't made clear in the documentation, I've made the appropriate changes. A randomly generated password is now used instead.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants