Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark fails occasionally due to imageDecodeTime being negative #88

Open
pastelmind opened this issue Jun 27, 2023 · 0 comments
Open
Assignees
Labels
type: bug Something isn't working

Comments

@pastelmind
Copy link
Collaborator

Benchmark for ag-psd occasionally fails with the following error: imageDecodeTime must be a nonnegative number

This is probably happening because of the rather fragile (and broken) way we currently use to measure the image decode time, i.e. by subtracting the parse time (measured separately) from the total render time:

imageDecodeTime:
parseAndImageRenderEnd - parseAndImageRenderBegin - parseTime,

The benchmark app is long overdue a rewrite anyway; I'm thinking of writing it in React.

@pastelmind pastelmind added the type: bug Something isn't working label Jun 27, 2023
@pastelmind pastelmind self-assigned this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant