Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add different interfaces for get mutable item? #159

Closed
thomas-yuan opened this issue Apr 18, 2017 · 1 comment
Closed

Add different interfaces for get mutable item? #159

thomas-yuan opened this issue Apr 18, 2017 · 1 comment

Comments

@thomas-yuan
Copy link

PR #157 fixed the mutable put with salt, but thinking about the interface, we actually export the logic (target = hash (public_key+salt)) to the user when they try to get a mutable item from DHT.

should we add a different interface for mutable item get like get(public_key, salt, callback) to make the interface more clearly? By this way, I, as a user, needn't care about how to calculate the hash, won't make the same mistake as what #157 fixed.

@feross
Copy link
Member

feross commented Apr 21, 2018

This issue appears stale since it has been open for a while with no activity. I'm going to close it for now. If this is still issue, please feel free to leave a comment or open a new issue.

@feross feross closed this as completed Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants