Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch folder #1154

Merged
merged 9 commits into from
Oct 17, 2017
Merged

Watch folder #1154

merged 9 commits into from
Oct 17, 2017

Conversation

codealchemist
Copy link
Contributor

In response to #1149, this feature adds a preference to watch a folder for new .torrent files.
When a torrent file is saved on the watched folder it is automatically added to WebTorrent Desktop.
The feature can be enabled / disabled from preferences.

image

@codealchemist
Working on watch-folder
a70c4d1 
Added chokidar to watch for folder changes; added folder-watcher;
passing state to delayedInit on main;  added default values for new
preferences; added “Auto add torrents” preference with its checkbox and
path selector; TODO: start/stop watching on preference change, start
watching on init, add dialog when trying to enable preference without a
torrents folder.
@codealchemist
fixed styling issues
a6c53d0
@codealchemist
added start / stop events; starting / stopping folder watcher.
7f81724
@codealchemist
fixed styling issue
4a8ab6e
@codealchemist
added folder-watcher-controller
996a81d
@codealchemist
Removed extra logging.
2ad3f6d
@codealchemist
Removed unused module from folderWatcher.
23eef1a
@codealchemist codealchemist mentioned this pull request Mar 29, 2017
Closed
@Flet
Copy link
Member

Flet commented Apr 1, 2017 •
edited

I really like this idea!

I think the wording on the the preferences could be phrased better as its not totally clear to me (and it doesn't mention "watching" at all)

Maybe:

(remove the header)

✅ Watch for new .torrent files and add them immediately.
Folder to watch: __________________________________________

Also, as this feature feels a little beyond the "keep things simple" user experience of this app, so it may be best to have this turned off by default. (EDIT: as I see in the code, already is off by default 😊)

@codealchemist
Copy link
Contributor Author

Hey @Flet, thanks a lot for your feedback!
I like the rewording and simplification.
About the header, I think we still need it because there aren't preferences without headers. If we just remove the header the preference will look like being part of another section.

Maybe we can rename Downloads to Folders and add it under that section.
@feross, @dcposch, what do you guys think about this change?

Cheers!

@codealchemist
Preferences update
b02d6f3 
Renamed “Downloads” section to “Folders”; watch folder preference moved
under “Folders”; updated texts for watch folder preference.
@codealchemist
Copy link
Contributor Author

Preview with proposed adjustments:

image

@codealchemist codealchemist requested review from Flet and removed request for grunjol and mathiasvr September 26, 2017 17:11
@codealchemist
Copy link
Contributor Author

Hey @Flet, can you provide a review to move this one forward?
Thanks!

@codealchemist codealchemist merged commit cae40b4 into master Oct 17, 2017
@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Flet Flet Flet approved these changes

@feross feross Awaiting requested review from feross

@dcposch dcposch Awaiting requested review from dcposch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codealchemist @Flet