Cleanup preferences page #1498
Merged
Cleanup preferences page #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
mathiasvr
force-pushed
the
cleanup-preferences
branch
from
2b833bf
to
f4926b5
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Let's try this again 😏 |
mathiasvr
force-pushed
the
cleanup-preferences
branch
2 times, most recently
from
48bf406
to
7b39c9a
Compare
mathiasvr
force-pushed
the
cleanup-preferences
branch
from
7b39c9a
to
f34a79d
Compare
|
@hicom150 Thanks for letting me know. I'll close those now :) Thanks, @mathiasvr! |
This was referenced Aug 18, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
displayValue, and always shows path instead.I think it makes sense to remove
displayValue, because it's only used to display the name of the external player, which is inconsistent with how we display other paths.Also, the player name is already displayed in a message above the path, so we don't lose that information.