Fix a few type errors #1720
Fix a few type errors #1720
Conversation
src/main/windows/webtorrent.js
Outdated
| @@ -26,7 +25,8 @@ function init () { | |||
| title: 'webtorrent-hidden-window', | |||
| useContentSize: true, | |||
| webPreferences: { | |||
| nodeIntegration: true | |||
| nodeIntegration: true, | |||
| backgroundThrottling: false // do not throttle animations/timers when page is background | |||
There was a problem hiding this comment.
I'm not sure this was in effect before, do we actually want to disable background throttling?
There was a problem hiding this comment.
Given that it was not in inside webPreferences I assume it was in it's default state: true. So I wouldn't change it here 😅
src/main/windows/webtorrent.js
Outdated
| @@ -26,7 +25,8 @@ function init () { | |||
| title: 'webtorrent-hidden-window', | |||
| useContentSize: true, | |||
| webPreferences: { | |||
| nodeIntegration: true | |||
| nodeIntegration: true, | |||
| backgroundThrottling: false // do not throttle animations/timers when page is background | |||
There was a problem hiding this comment.
Given that it was not in inside webPreferences I assume it was in it's default state: true. So I wouldn't change it here 😅
src/main/windows/main.js
Outdated
| @@ -44,7 +43,8 @@ function init (state, options) { | |||
| useContentSize: true, // Specify web page size without OS chrome | |||
| width: initialBounds.width, | |||
| webPreferences: { | |||
| nodeIntegration: true | |||
| nodeIntegration: true, | |||
| backgroundThrottling: false // do not throttle animations/timers when page is background | |||
There was a problem hiding this comment.
Given that it was not in inside webPreferences I assume it was in it's default state: true. So I wouldn't change it here 😅
|
Great work @mathiasvr 👍 |
|
@hicom150 Thanks for the review, I have updated the PR to remove the |
|
I actually think we want |
Reference: #1720 (comment) I actually think we want backgroundThrottling: false so our timers and intervals aren't throttled when the app is backgrounded.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:
What changes did you make? (Give an overview)
Fixes type errors, mainly according to new Electron version.