Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable background throttling #1886

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Disable background throttling #1886

merged 1 commit into from
Nov 5, 2020

Conversation

feross
Copy link
Member

@feross feross commented Nov 4, 2020

Reference: #1720 (comment)

I actually think we want backgroundThrottling: false so our timers and intervals aren't throttled when the app is backgrounded.

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)

Disable background throttling. See https://www.electronjs.org/docs/api/browser-window

Which issue (if any) does this pull request address?

None

Is there anything you'd like reviewers to focus on?

Reference: #1720 (comment)

I actually think we want backgroundThrottling: false so our timers and intervals aren't throttled when the app is backgrounded.
@feross feross mentioned this pull request Nov 4, 2020
Copy link
Contributor

@hicom150 hicom150 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@feross feross merged commit 0cd0edf into master Nov 5, 2020
@feross feross deleted the throttling branch November 5, 2020 21:30
@feross
Copy link
Member Author

feross commented Nov 5, 2020

Thanks for the reviews, @hicom150 and @alxhotel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants