Associate .torrent files to WebTorrent Desktop (OS X) #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, .torrent files would only be associated to WebTorrent Desktop if another torrent client (like Transmission) was installed on the system. That's because one of the user's apps needs to define "UTExportedTypeDeclarations". On a fresh machine, without Transmission, WebTorrent Desktop now associates .torrent files correctly. So it will appear in the "Open With..." menu and the webtorrent .torrent icon will be used for .torrent files. Closes #542.
|
LGTM. Eventually we should have a prefs page with an option for whether you want Webtorrent to be the default app for |
mathiasvr
pushed a commit
to mathiasvr/webtorrent-desktop
that referenced
this pull request
May 26, 2016
Before this change, .torrent files would only be associated to WebTorrent Desktop if another torrent client (like Transmission) was installed on the system. That's because one of the user's apps needs to define "UTExportedTypeDeclarations". On a fresh machine, without Transmission, WebTorrent Desktop now associates .torrent files correctly. So it will appear in the "Open With..." menu and the webtorrent .torrent icon will be used for .torrent files. Closes webtorrent#542.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, .torrent files would only be associated to
WebTorrent Desktop if another torrent client (like Transmission) was
installed on the system.
That's because one of the user's apps needs to define
"UTExportedTypeDeclarations".
On a fresh machine, without Transmission, WebTorrent Desktop now
associates .torrent files correctly.
So it will appear in the "Open With..." menu and the webtorrent
.torrent icon will be used for .torrent files.
Closes #542