-
-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new protocol handler: stream-magnet #640
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -549,7 +549,7 @@ function onOpen (files) { | |
function isTorrent (file) { | ||
var name = typeof file === 'string' ? file : file.name | ||
var isTorrentFile = path.extname(name).toLowerCase() === '.torrent' | ||
var isMagnet = typeof file === 'string' && /^magnet:/.test(file) | ||
var isMagnet = typeof file === 'string' && /^magnet:/.test(file) || /^stream-magnet:/.test(file) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would put parens around the magnet regexes for clarity -- I can never remember the order of ops of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This also could be like |
||
return isTorrentFile || isMagnet | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't remove
magnet
, since we support both in Windows/Linux.