new protocol handler: stream-magnet #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only tested on windows
anonymlol
changed the title
| @@ -549,7 +549,7 @@ function onOpen (files) { | |||
| function isTorrent (file) { | |||
| var name = typeof file === 'string' ? file : file.name | |||
| var isTorrentFile = path.extname(name).toLowerCase() === '.torrent' | |||
| var isMagnet = typeof file === 'string' && /^magnet:/.test(file) | |||
| var isMagnet = typeof file === 'string' && /^magnet:/.test(file) || /^stream-magnet:/.test(file) | |||
There was a problem hiding this comment.
I would put parens around the magnet regexes for clarity -- I can never remember the order of ops of || and &&.
There was a problem hiding this comment.
This also could be like var isMagnet = typeof file === 'string' && /^(stream-)?magnet:/.test(file)
|
LGTM, with a couple of exceptions inline. I'll fix them up after merge. Thanks for the contribution! |
|
I also had to add support for |
djjorjinho
pushed a commit
to djjorjinho/webtorrent-desktop
that referenced
this pull request
Jun 30, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #83
Only tested on Windows.