Added progress bar to the metadata on the overview #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide a print screen? |
| @@ -105,6 +106,11 @@ module.exports = class TorrentList extends React.Component { | |||
|
|
|||
| return (<div key='metadata' className='metadata'>{elements}</div>) | |||
|
|
|||
| function renderProgressBar () { | |||
| var progress = Math.floor(100 * prog.progress) | |||
| return (<progress value={progress} max='100'>{progress}%</progress>) | |||
|
Here's what it looks like now:
I think it's a good start, but needs a bit of CSS. |
|
@PurgingPanda how about this?
Smaller progress bar plus a bit of spacing. progress {
width: 60px;
margin-right: 8px;
} |
As proposed by dcposh.
|
LGTM |
|
Good idea. It doesn't look that nice on Windows though:
I |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#796
Added simple progress bar using the build in html tag.
I hope this (minor) addition is usefull.