Ensure that default file/protocol handlers are re-installed after updating.

[bnjmnt4n]

Previously, they were only installed when the preference was changed. This caused the handlers to point to non-existing files after updates occurred and older versions were removed by Squirrel.

Closes #791, #911.

[bnjmnt4n]

Also, it seems weird that state.js is in the renderer folder, when it is called by both the renderer and main processes. Also, I think migrations.js belongs in the main folder, as it is typically only called to migrate updates by the main process. Maybe we should check which process it is in to decide which code to call?

[dcposch]

state.js should only be used from the renderer process. Migrations also run in the renderer process.

I like the idea of reinstalling handlers on every app update though!

Only caveat is that someone might get frustrated if they remove handlers via Control Panel / System Preferences and they keep coming back

[dcposch]

I don't think you can do this from the renderer process.

You have to use ipcRenderer to tell the main process to reinstall the handlers.

[bnjmnt4n]

@dcposch I believe that currently state.js is run on both renderer and main processes, as it is loaded in the main process in order to restore window bounds.

[feross]

I believe that currently state.js is run on both renderer and main processes, as it is loaded in the main process in order to restore window bounds.

You're right. state.js is required in both processes at the moment. That came in with the bound restoration change. I added a change in #995 that makes migrations only run once in the renderer (for perf, and bug prevention). state.save() should never be called from the main process, or we'll have serious problems. Not sure what the cleanest solution is here.

[bnjmnt4n]

@feross I'll try to rebase on master and change the code to account for #773, which I hadn't seen before doing this PR.

[bnjmnt4n]

@feross for now I've just set up the IPC renderer to install the handlers after every update. I'll look into #773 in the future.

[bnjmnt4n]

Any updates?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.