Breaking changes #235

hassandraga · 2023-10-01T03:37:33Z

hassandraga
Oct 1, 2023
Maintainer

1 - A new element in the browser struct:

enum webui_browsers {
    NoBrowser = 0, // 0. No web browser
    ...
};

Start the server only without any browser call webui_show_browser with NoBrowser:

webui_set_timeout(0);
return webui_show_browser(window, content, NoBrowser);
const char* url = webui_get_url(myWindow);

2 - Two new functions to delete window local folder profiles:

webui_delete_profile(myWindow);
webui_delete_all_profiles();

3 - New webui_clean() to clean memory (Optional)

// create/show windows...
webui_wait();
// You can re-create/re-show windows again if you want...
webui_clean();
// Now. WebUI is unusable.

4 - 39f9ab0

- Removed WEBUI_EVENT_MULTI_CONNECTION
- Removed WEBUI_EVENT_UNWANTED_CONNECTION
- Removed webui_set_multi_access()

5 - 6d5612c

- Removed: webui_interface_get_bind_id()
- Add: webui_event_t -> size_t bind_id

Wrappers that have internal-event-handler may call by mistake 
the same callback twice when app use all-events. To fix this issue, 
simply wrappers should replace 
`webui_interface_get_bind_id()` by `e.bind_id`.

Info:

The core is changed/re-designed to handle and process events faster than before. Fewer memory copies as possible. Now you can call something like setInterval(function(){ webui.call('myFunc'); }, 10); every 10ms.

Note:
I'm working on multi-arguments, and token secured connections to prevent unwanted usage of webui.js.

hassandraga · 2023-10-02T00:47:04Z

hassandraga
Oct 2, 2023
Maintainer Author

Re-design again (e7418ef)
Now events can go up to 10ms without any miss.

7 replies

hassandraga Oct 2, 2023
Maintainer Author

I re-tested it (C). Works fine. Please make sure you are using the latest commit and binaries.
If it still fails, please share the logs in a new issue.

ttytm Oct 2, 2023
Maintainer

text-editor is the only example that shows up for me. Logs for e.g., call_c_from_js:

[User] webui_new_window()...
[Core]          WebUI v2.4.0 
[Core]          _webui_init()...
[Core]          _webui_get_current_path()...
[User] webui_get_new_window_id()...
[User] webui_new_window() -> New window #1 @ 0x0x12a00b000
[User] webui_bind([1], [MyID_One], [0x0x104152d60])...
[Core]          _webui_get_cb_index([1/MyID_One])...
[Core]          _webui_set_cb_index([1/MyID_One])...
[User] webui_bind([1], [MyID_Two], [0x0x104152da0])...
[Core]          _webui_get_cb_index([1/MyID_Two])...
[Core]          _webui_set_cb_index([1/MyID_Two])...
[User] webui_bind([1], [MyID_Three], [0x0x104152de0])...
[Core]          _webui_get_cb_index([1/MyID_Three])...
[Core]          _webui_set_cb_index([1/MyID_Three])...
[User] webui_bind([1], [MyID_Four], [0x0x104152ef8])...
[Core]          _webui_get_cb_index([1/MyID_Four])...
[Core]          _webui_set_cb_index([1/MyID_Four])...
[User] webui_bind([1], [MyID_RawBinary], [0x0x104152e3c])...
[Core]          _webui_get_cb_index([1/MyID_RawBinary])...
[Core]          _webui_set_cb_index([1/MyID_RawBinary])...
[User] webui_show([1])...
[Core]          _webui_find_the_best_browser()...
[Core]          _webui_is_process_running([Google Chrome])...
[Core]          _webui_is_process_running([Epic])...
[Core]          _webui_is_process_running([Vivaldi])...
[Core]          _webui_is_process_running([Brave])...
[Core]          _webui_is_process_running([Firefox])...
[Core]          _webui_is_process_running([Yandex])...
[Core]          _webui_is_process_running([Chromium])...
[Core]          _webui_show([1])...
[Core]          _webui_show() -> Embedded HTML:
- - -[HTML]- - - - - - - - - -
<!DOCTYPE html><html>  <head>    <meta charset="UTF-8">    <script src="webui.js"></script>    <title>Call C from JavaScript Example</title>    <style>      body {        background: linear-gradient(to l
eft, #36265a, #654da9);        color: AliceBlue;        font: 16px sans-serif;        text-align: center;        margin-top: 30px;      }      button {        margin: 5px 0 10px;      }    </style>  </he
ad>  <body>    <h1>WebUI - Call C from JavaScript</h1>    <p>Call C functions with arguments (<em>See the logs in your terminal</em>)</p>    <button onclick="webui.call('MyID_One', 'Hello');">Call my_fun
ction_string()</button>    <br>    <button onclick="webui.call('MyID_Two', 123456789);">Call my_function_integer()</button>    <br>    <button onclick="webui.call('MyID_Three', true);">Call my_function_b
oolean()</button>    <br>    <button onclick="webui.call('MyID_RawBinary', new Uint8Array([0x41, 0x42, 0x43]));">Call my_function_raw_binary()</button>    <br>    <p>Call a C function that returns a resp
onse</p>    <button onclick="MyJS();">Call my_function_with_response()</button>    <div>Double: <input type="text" id="MyInputID" value="2"></div>    <script>      function MyJS() {        const MyInput 
= document.getElementById('MyInputID');        const number = MyInput.value;        webui.call('MyID_Four', number).then((response) => {            MyInput.value = response;        });      }    </script
>  </body></html>
- - - - - - - - - - - - - - - -
[Core]          _webui_show_window(HTML, [1])...
[Core]          _webui_get_free_port()...
[Core]          _webui_port_is_used([13833])...
[Core]          _webui_socket_test_listen_mg([13833])...
[Core]          _webui_get_free_port()...
[Core]          _webui_port_is_used([29394])...
[Core]          _webui_socket_test_listen_mg([29394])...
[User] webui_is_shown([1])...
[Core]          _webui_browser_start([http://localhost:13833], [1])...
[Core]          _webui_free_mem(0x0x11a008200)...
[Core]          _webui_free_mem(0x0x11a008200) -> Free 2048 bytes
[Core]          _webui_free_mem(0x0x600003f64000)...
[Core]          _webui_free_mem(0x0x600003f64000) -> Free 64 bytes
[Core]          _webui_free_port([13833])...
[Core]          _webui_free_port([29394])...
[Loop] webui_wait()...
[Loop] webui_wait() -> No window is found. Stop.
[User] webui_clean()...
[Core]          _webui_clean()...
[Core]          _webui_free_all_mem()...
[Core]          _webui_free_all_mem() -> Free 2048 bytes @ 0x0x12a00a000
[Core]          _webui_free_all_mem() -> Free 2048 bytes @ 0x0x12a00a800
[Core]          _webui_free_all_mem() -> Free 8192 bytes @ 0x0x12a00b000
[Core]          _webui_free_all_mem() -> Free 2048 bytes @ 0x0x12a00d000
[Core]          _webui_free_all_mem() -> Free 2048 bytes @ 0x0x12a00d800
[Core]          _webui_free_all_mem() -> Free 16 bytes @ 0x0x600002864050
[Core]          _webui_free_all_mem() -> Free 16 bytes @ 0x0x600002864060
[Core]          _webui_free_all_mem() -> Free 16 bytes @ 0x0x600002864070
[Core]          _webui_free_all_mem() -> Free 16 bytes @ 0x0x600002864080
[Core]          _webui_free_all_mem() -> Free 32 bytes @ 0x0x600002a611c0
[Core]          _webui_free_all_mem() -> Free 32 bytes @ 0x0x600002a64000
[Core]          _webui_free_all_mem() -> Free 32 bytes @ 0x0x600002a68000
[Core]          WebUI exit successfully.

MacOS currently is still all I have available to test locally.

But the tests in the V-wrapper (run on linux) fail as well:

---- Testing... ----------------------------------------------------------------
--------------------------------------------------------------------------------
running tests in: /home/runner/.vmodules/vwebui/tests/call_js_from_v_test.v
/home/runner/.vmodules/vwebui/tests/call_js_from_v_test.v:24: fn test_js_fn_call
    assert false, err.str()
        Message: Failed showing window.

https://github.com/webui-dev/v-webui/actions/runs/6372357884/job/17301730612

ttytm Oct 2, 2023
Maintainer

CI test for V now re-run with logs if they fail:
https://github.com/webui-dev/v-webui/actions/runs/6378903454/job/17310382269

hassandraga Oct 2, 2023
Maintainer Author

That's actually a good catch. Thank you for the report.
The issue was after adding NoBrowser, I forgot to update the internal core function _webui_browser_start().

Fixed (a9fa6fa)

ttytm Oct 2, 2023
Maintainer

Nice, thanks for the fix. I'm gonna give it a shot tomorrow 🙂👍

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Breaking changes #235

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 1 comment 7 replies

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

Select a reply

Breaking changes #235

hassandraga Oct 1, 2023 Maintainer

Replies: 1 comment · 7 replies

hassandraga Oct 2, 2023 Maintainer Author

hassandraga Oct 2, 2023 Maintainer Author

ttytm Oct 2, 2023 Maintainer

ttytm Oct 2, 2023 Maintainer

hassandraga Oct 2, 2023 Maintainer Author

ttytm Oct 2, 2023 Maintainer

hassandraga
Oct 1, 2023
Maintainer

Replies: 1 comment 7 replies

hassandraga
Oct 2, 2023
Maintainer Author

hassandraga Oct 2, 2023
Maintainer Author

ttytm Oct 2, 2023
Maintainer

ttytm Oct 2, 2023
Maintainer

hassandraga Oct 2, 2023
Maintainer Author

ttytm Oct 2, 2023
Maintainer