xfer got problems with 'xfer.file.auto_rename'

[bsdcpp]

Bug summary

weechat v3.1
When I download files from irc.undernet.org#bookz, if you download the same file (named file.epub) agian, you'll always get file.epub.1, file.epub.2 ......, seems the /set config doesn't work.

Steps to reproduce

 xfer.file.auto_accept_chats          boolean  on
 xfer.file.auto_accept_files          boolean  on
 xfer.file.auto_accept_nicks          string   ""
 xfer.file.auto_check_crc32           boolean  off
 xfer.file.auto_rename                boolean  off
 xfer.file.auto_resume                boolean  on
 xfer.file.convert_spaces             boolean  off
 xfer.file.download_path              string   "~/Downloads/weechat"
 xfer.file.download_temporary_suffix  string   ".part"
 xfer.file.upload_path                string   "~"
 xfer.file.use_nick_in_filename       boolean  off

1. set xfer.file like above
2. connect network irc.undernet.org, join #bookz channel
3. search one thing like: @search harry potter, then download one of them;
4. download the file again, you'd get filename.1, again filename.2

Current behavior

Expected behavior

don't download files again when exists.

Suggested solutions

Additional information

---

• WeeChat version: v3.1, installed with brew
• OS, distribution and version: macos big sur 11.2.2
• Terminal: iTerm
• Terminal multiplexer (screen/tmux/…/none): none

[bsdcpp]

weechat/src/plugins/xfer/xfer-file.c

Line 188 in bcd889c

if (!xfer_config_file_auto_rename)

maybe this line should be

if (!weechat_config_boolean (xfer_config_file_auto_rename))

Please check this out, thanks.

[bsdcpp]

Would you please set the stauts to aborted(XFER_STATUS_ABORTED), people will be confused with the failed msg.
Or maybe add a new status, tell people this is a duplication one.