Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix vidiffr plot tests on CMD check #84

Open
juniperlsimonis opened this issue Dec 12, 2018 · 2 comments
Open

fix vidiffr plot tests on CMD check #84

juniperlsimonis opened this issue Dec 12, 2018 · 2 comments

Comments

@juniperlsimonis
Copy link
Member

work locally under testing and on travis under testing, but fail when check is used
ref: https://github.com/lionel-/vdiffr/issues/52
@juniperlsimonis juniperlsimonis modified the milestone: CRAN submission Dec 12, 2018
@juniperlsimonis
Copy link
Member Author

It looks like it might be a little bit of time before this gets addressed (the issue linked to above describes the situation I'm experiencing), so for the time being, I've set up a way to toggle the testing of the plots for within cran builds to only testing that the plot functions work without throwing errors or warnings. the vidffr tests are still in the testing scripts, but now they're only employed if the tenv variable at the top of the scripts (lda_plot, LDA_TS_plots, TS_plots) to something other than "cran". this allows us to retain the code for testing in the development space but not have it trip up during R CMD check.
i've therefore removed the milestone for this for now.

@juniperlsimonis
Copy link
Member Author

this toggle is included in #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@juniperlsimonis