New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Android.mk to build using android NDK #3
Conversation
069b3c4
to
a462cf8
Compare
I have not forgot about this request. I need to get with folks and see where we should put it. |
@alex - I want to grab this one eventually, too. I need to talk to Wei about adding a By the way, do you do Cmake? If so, that's another one I would like for users who want it. |
@alex - This is now up for debate at Android setenv script. If all goes well, we will grab it in a week or two. |
045b07f
to
89b0fa7
Compare
I really want the |
Just wanted to pop up and suggest that the source file list be split into a separate file that each |
Status? |
I was able to build for all platforms using Android.mk
Application.mk
Command line
|
Thanks @Deadpikle. So it looks like thrust of your change was to add I'll need a few days to test things and write-up a wiki page. With the fix and documentation we should be able to merge it. Thanks to @cawka for the initial PR and @Deadpikle for the update. |
@noloader There are a few other things that I might as well document here for the future:
This block fixes issues with using
As far as not duplicating the source list goes, you can apparently use a wildcard selection of .cpp files as seen here: https://stackoverflow.com/a/8980441/3938401
But with the test files and the source files in the same directory, I haven't yet found a way to do a wildcard and then take out the test files (Searching on Google has failed me; it's possible there is a way 😜). Just to save you some Google time when making that wiki page if you need these links:
|
Well, there's a few issues. We do just filter them out in the makefile: You need to order the object files like the makefile does. Also see Static Initialization Order Fiasco. You also need to sort the files by name for PR #426, Have constant link order.
Thanks. I did not know another library was needed for it. |
@noloader It appears as though Android.mk is a standard make file, so we can actually just do the same thing as GNUmakefile-cross to grab filenames (I filtered out test files in this sample): Android.mk
This compiles everything in the order given in
...suffice it to say, if you look through there, it links in this order: Edit: The above Android.mk works as of commit 7097546 for the record |
I will note that removing
This can be fixed by passing in There's some other issues on other architectures that seem to pop up via |
The library uses strategy (2) in
|
Here's a version that doesn't have Application.mk
Android.mk
Edit: I will note that I haven't actually, you know, tested the actual binaries to work on all the platforms as of this post. 😅 |
We added a repo to independently provide Android.mk support at Noloader | cryptopp-android. The initial check-in is complete. Now we have to fix it and tune it. We sent you collaborator invites so you won't be stalled waiting for us to act. Sorry about dragging our ass on it. |
The Androidmk source files have gone through a major revision. We got all the build flag issues solved. Also see https://github.com/noloader/cryptopp-android We are still keeping |
I sent you guys invites to be Collaborators for cryptopp-android. It is my GitHub. We need some fallback Collaborators if I get hit by a bus. It should not be a big burden on you. I'll keep it up to date. |
@noloader Thanks. I accepted. Although I hope no one gets hit by a bus, I certainly understand wanting to keep things alive if something happens. 😄 Thanks also for the notification of the changes -- been a long while since I've looked at this for the project I was working on. |
No description provided.