Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running example folder with 2.0.0 fresh lib produce [vite] Internal server error: failed to resolve "extends":"@tsconfig/create-react-app/tsconfig.json" in example/tsconfig.json #194

Closed
leobastiani opened this issue Apr 16, 2023 · 5 comments

Comments

@leobastiani
Copy link

To reproduce

npx dts-cli create mylib --template react
cd mylib
yarn build
cd example
yarn
yarn start
yarn run v1.22.19
$ vite
▲ [WARNING] Cannot find base config file "@tsconfig/create-react-app/tsconfig.json" [tsconfig.json]

    tsconfig.json:2:13:
      2 │   "extends": "@tsconfig/create-react-app/tsconfig.json"
        ╵              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


  VITE v4.2.1  ready in 642 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  ➜  press h to show help
11:28:11 AM [vite] Internal server error: failed to resolve "extends":"@tsconfig/create-react-app/tsconfig.json" mylib/example/tsconfig.json

Could it be possible update example folder and use typescript 5 on it?

Thank you ❤️

@aladdin-add
Copy link

Thanks for letting me know. to fix it, you can just replace it with @tsconfig/vite-react/tsconfig.json.

I'll push a fix soon.

@leobastiani
Copy link
Author

thank you ❤️
what do you think of adding a pipe line to test example folder?

@aladdin-add
Copy link

sure, that's' exactly what I'm thinking. Would you like to make a PR?

@leobastiani
Copy link
Author

leobastiani commented Apr 17, 2023 via email

@aladdin-add
Copy link

I also think it should be nice setting fixed versions of all packages in
usage and updating then everyday automatically if no errors were found
what do you think?

sounds good to me! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants