Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicates in feed and next page fetching for "New" and "Jobs" posts #222

Merged
merged 2 commits into from
Dec 5, 2021
Merged

Fix duplicates in feed and next page fetching for "New" and "Jobs" posts #222

merged 2 commits into from
Dec 5, 2021

Conversation

JeffreyCA
Copy link
Contributor

@JeffreyCA JeffreyCA commented Dec 5, 2021 •
edited

Fixes #194 and #54

  • Duplicate posts may show up in the feed when you scroll to load next posts (this happens when post ranking changes in between).
  • Currently if you scroll through "New" or "Jobs" posts, it reloads the same set of posts over and over again because their API uses post IDs instead of page numbers.

Let me know if I should change anything - I'm pretty new to Swift.

I really love the app!

@weiran
Copy link
Owner

weiran commented Dec 5, 2021

Thank you @JeffreyCA!

@weiran weiran merged commit 2247ff7 into weiran:master Dec 5, 2021
@JeffreyCA
Copy link
Contributor Author

Hi @weiran are you planning a release with these fixes soon?

@weiran
Copy link
Owner

weiran commented Dec 18, 2021

@JeffreyCA Will get a new build out before Christmas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrolling in "New" and "Jobs" shows the same posts over and over again
2 participants
@JeffreyCA @weiran