Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate stories #54

Closed
JeffreyCA opened this issue Nov 15, 2018 · 2 comments
Closed

Duplicate stories #54

JeffreyCA opened this issue Nov 15, 2018 · 2 comments

Comments

@JeffreyCA
Copy link
Contributor

I see duplicate entries when scrolling multiple pages down.

a56b01a5-a46e-43b0-a28d-576c675c37de

@weiran
Copy link
Owner

weiran commented Nov 27, 2018

Thanks for the feedback. I believe this may be related to Hacker News changing the ranking of posts and then returning duplicates if a post from the current page drops below the cutoff to the next page.

I can't reproduce it this testing on live data (fetching the next page recently from the previous one). Feel free to reopen this if you can regularly replicate and I'll have a look again.

@weiran weiran closed this as completed Nov 27, 2018
@JeffreyCA
Copy link
Contributor Author

It happens quite regularly. In my case I read a few stories, which can take several minutes, go back, then scroll down the list of stories, continue. This is a pretty natural way of using the app, which is different from continuously scrolling down in one go when you tried to reproduce it.

Can you take a look again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants