-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It looks like click on a label for a checkbox is not dispatched in darklaf #24
Comments
This should be fixed in ffc248f. I will upload a new version later this day or tomorrow. |
The menu bar not being in the OsX menu bar is indeed odd. Could you tell me the value of |
It is set. As you see on the screenshots above it does work (see bulenkov/darcula where the menu is not present). I launch JMeter with exactly the same command, and the only difference is different themes. Note: the application itself does not modify useScreenMenuBar property, and the property is passed during the startup: https://github.com/apache/jmeter/blob/cfb2bd92acf19123ae8a0de32ca60a46f5a85043/src/dist/build.gradle.kts#L520 |
Ok. I was able to execute Thanks for the quick fix. |
In the screenshot the comment text area has the wrong background outside the border. |
@weisJ , that is interesting. By default Swing does not put the border around textarea, so JMeter adds its own border. Will check shortly. |
I have tried to apply darklaf to Apache JMeter, and below are some samples.
The issue I have is checkboxes and radioboxes can not be flipped by clicking on the relevant labels.
For instance, here's the code that creates radio buttons:
https://github.com/apache/jmeter/blob/b6d11d79d905d0c099732bb928d2372fd1388981/src/components/src/main/java/org/apache/jmeter/sampler/gui/TestActionGui.java#L210
With other LaFs (e.g. Darcula) I can click on labels like
Infinite
,Continue
,Stop Test
, and they alter the checkboxes.PS. I can't build darklaf as it fails with
windows.h
not found (I use macOS)Apache JMeter with bulenkov/darcula:
Apache JMeter with weisJ/darflaf/darcula (it is strange the menu is not moved to Apple's menu):
Apache JMeter with weisJ/darflaf/IntelliJ (just in case):
The text was updated successfully, but these errors were encountered: