Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WP CLI Configuration File Check #597

Merged
merged 19 commits into from
May 16, 2020
Merged

WP CLI Configuration File Check #597

merged 19 commits into from
May 16, 2020

Commits on Apr 23, 2020

  1. Detect if wp-cli.yml exists in wordpress_path before applying --path opt

    @maiorano84
    maiorano84 committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    8029676 View commit details
    Browse the repository at this point in the history

  2. Fix test

    @maiorano84
    maiorano84 committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    58d2ca8 View commit details
    Browse the repository at this point in the history

  3. Fix code linting

    @maiorano84
    maiorano84 committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    9074f03 View commit details
    Browse the repository at this point in the history

  4. Add extra test case to cover both wp-cli.yml scenarios

    @maiorano84
    maiorano84 committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    b041884 View commit details
    Browse the repository at this point in the history

  5. Fix test case (unnecessary whitespace)

    @maiorano84
    maiorano84 committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    7a6af4d View commit details
    Browse the repository at this point in the history

  6. Derp

    @maiorano84
    maiorano84 committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    5d9091c View commit details
    Browse the repository at this point in the history

  7. Code style fixes

    @maiorano84
    maiorano84 committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    d783871 View commit details
    Browse the repository at this point in the history

  8. Code style fixes

    @maiorano84
    maiorano84 committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    4b24f78 View commit details
    Browse the repository at this point in the history

  9. Code style fixes

    @maiorano84
    maiorano84 committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    ba04f93 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. Deeper configuration search

    @maiorano84
    maiorano84 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    399aa16 View commit details
    Browse the repository at this point in the history

  2. Fix test

    @maiorano84
    maiorano84 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    1041220 View commit details
    Browse the repository at this point in the history

  3. Style linter

    @maiorano84
    maiorano84 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    c33c2ee View commit details
    Browse the repository at this point in the history

  4. Derp

    @maiorano84
    maiorano84 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    c35de3d View commit details
    Browse the repository at this point in the history

  5. Style fixes

    @maiorano84
    maiorano84 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    7f9096f View commit details
    Browse the repository at this point in the history

  6. Style fixes

    @maiorano84
    maiorano84 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    b924a04 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2020

  1. Add fixture_folder_path and fixture_folder_root_relative_path to fixt… 

    …ure helpers
    @alessandro-fazzi
    alessandro-fazzi committed May 9, 2020
    Configuration menu
    Copy the full SHA
    8647141 View commit details
    Browse the repository at this point in the history

  2. Add fixture file for wp-cli.yml

    @alessandro-fazzi
    alessandro-fazzi committed May 9, 2020
    Configuration menu
    Copy the full SHA
    463a68b View commit details
    Browse the repository at this point in the history

Commits on May 10, 2020

  1. Refactor SqlAdapter::Wpcli spec 

    Generally what I'm trying to do is to
avoid "overmocking". There were too much
stub we was relying on, but I opted to
maintain only the one about invoking the
`wp` command, so that we don't need to have
the binary in the repo for running tests.

I've also corercted the texts and reorganized
the contexts with a different nesting. Now they
look like this:

```
Wordmove::SqlAdapter::Wpcli
  #command
     having wp-cli.yml in local_path
      returns the right command as a string
    without wp-cli.yml in local_path
      but still reachable by wp-cli
        returns the right command as a string
    without any wp-cli configuration
      returns the right command with '--path' flag set to local_path
```
    @alessandro-fazzi
    alessandro-fazzi committed May 10, 2020
    Configuration menu
    Copy the full SHA
    8d0ee2b View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from pioneerskies/maiorano-pr-597-review 

    Maiorano pr 597 review
    @maiorano84
    maiorano84 committed May 10, 2020
    Configuration menu
    Copy the full SHA
    df939b3 View commit details
    Browse the repository at this point in the history