Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[recommendation] smart case feature #46

Closed
kevin4fly opened this issue Nov 1, 2014 · 8 comments · Fixed by #48
Closed

[recommendation] smart case feature #46

kevin4fly opened this issue Nov 1, 2014 · 8 comments · Fixed by #48

Comments

@kevin4fly
Copy link

hi @wellle , is it able to add the smart case feature? or even add the fuzzy match feature, just like what other completion plugins did?

so far, it is pretty nice!

@wellle
Copy link
Owner

wellle commented Nov 1, 2014

Respecting ignorecase and smartcase should be quite straight forward. Fuzzy matching is a bit more involved since it would probably need to be implemented in the shell script itself.

@justinmk
Copy link
Contributor

justinmk commented Nov 1, 2014

Neocomplete does fuzzy matching, why reinvent it?

@wellle
Copy link
Owner

wellle commented Nov 1, 2014

@justinmk: Solid point!

@kevin4fly: Try integrating tmux-complete with Neocomplete. That combination should already support smart case and fuzzy matching.

I'll still consider adding smart case support to tmux-complete itself.

@kevin4fly
Copy link
Author

@wellle @justinmk thanks for you guys reply.

i have to say there are so many completion plugins, no all people use neocomplete. these kind of completion plugins are pretty heavy since they are collecting words or other information in background. i can only choose one and now i am using YouCompleteMe for completing which is quite suit for me.

YCM support fuzzy completion also, but it doesn't provide this feature when working together with tmux-complete.

anyway, ignore case and smart case are sufficient i think. thanks for your guys nice work again!

@wellle
Copy link
Owner

wellle commented Dec 23, 2014

@kevin4fly: I added support for 'ignorecase' and 'smartcase' in #48. Please let me know if anything doesn't work as expected.

Thanks for the recommendation 👍

@kevin4fly
Copy link
Author

@wellle Sorry for the belated reply.

I have checked the ignorecase and smartcase feature. Unfortunately, tmux-complete.vim doesn't work well with YouCompleteMe. There is not any response from vim after pressing <c-space>, of course that I have set let g:tmuxcomplete#trigger = 'omnifunc' in my vimrc.

Here now, I don't know if the matter is on YouCompleteMe or tmux-complete.vim since both of them have changed the code recently. I hope that you could take a look into this to see what is going on there.

@wellle
Copy link
Owner

wellle commented Dec 28, 2014

@kevin4fly: Please open a new issue. Currently I don't have YouCompleteMe installed, so I can't check easily.

@kevin4fly
Copy link
Author

I have added anther issue #49 to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants