Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿️ fix(a11y): update heading tags #140

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Conversation

welpo
Copy link
Owner

@welpo welpo commented Sep 9, 2023

Summary

This PR addresses issue #133, aiming to improve accessibility by introducing <h1> tags in key sections.

Changes Made

  • Converted .article-title from <div> to <h1>.
  • Used <h1> tags for .section-title and #home-banner-header.
  • Changed individual project names to use <h2> tags.
  • Modified blog listing post titles to use <h2> tags.
  • Updated CSS styling to keep the styling the same.

Reasoning

The use of <h1> tags is a standard practice for enhancing web accessibility. These changes align the project with best practices and make the content more accessible to screen readers and other assistive technologies.

@welpo welpo added the bug Something isn't working label Sep 9, 2023
@welpo welpo merged commit 0055a36 into main Sep 9, 2023
1 check passed
@welpo welpo deleted the fix/use-proper-heading-elements branch September 9, 2023 16:03
@welpo welpo changed the title ♿️ feat(a11y): update heading tags ♿️ fix(a11y): update heading tags Sep 9, 2023
@welpo welpo mentioned this pull request Sep 9, 2023
@welpo welpo linked an issue Sep 9, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use <h1> tags for titles
1 participant