✨ feat(comments): allow page override of global system #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactors the logic to check if the systems are enabled to be more maintainble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the ability to override global settings for comment systems at the page-level. Additionally, it refactors the existing code to make it more concise and maintainable.
Changes
Page-specific overrides: Adds the capability to disable comment systems on individual pages, overriding global settings. Useful for non-articles like "about", "privacy policy", etc. For example, if you have isso enabled globally, you can disable it for a specific page with
isso = false.Code refactoring: Simplifies the existing logic by using loops and making the code more DRY (Don't Repeat Yourself).
Documentation: This feature is documented in the Mastering tabi post.
Technical details
The Tera template code for enabling comment systems has been refactored to iterate over an array of systems. This makes it easier to manage and extend.