Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wyg support for IDE #537

Merged
merged 8 commits into from
Jan 15, 2020
Merged

Wyg support for IDE #537

merged 8 commits into from
Jan 15, 2020

Conversation

antfu
Copy link
Member

@antfu antfu commented Jan 14, 2020

I have finally come to this stage! 🤪

image


https://deploy-preview-537--wenyan-lang.netlify.com/ide

WIP

  • I am planning to add wyg packages to the explorer for reference (maybe after examples)
  • Maybe we can create a setting panel (just like help panel) and move the checkboxes inside

Would love to know what you think!

@LingDong-
Copy link
Member

Very nice!

  • Maybe we can have some indication (perhaps in compiled JS) about where each module is imported from, now that there are many sources

  • Setting panel sound good. But since currently that aren't that many options. Maybe leaving them outside is ok and in fact more discoverable. But I also think that a setting panel eventually will be needed, so might as well have them now. All depends on what you would like to work on :)

Looking forward to it!

@antfu
Copy link
Member Author

antfu commented Jan 15, 2020

Maybe we can have some indication (perhaps in compiled JS) about where each module is imported from, now that there are many sources

Sounds great. I think I can add that on next module wrapper refactor (to support py and rb as well)

Setting panel sound good. But since currently that aren't that many options. Maybe leaving them outside is ok and in fact more discoverable. But I also think that a setting panel eventually will be needed, so might as well have them now. All depends on what you would like to work on :)

You are right. Let's keep them outside for now. I have restyled the default components to match the overall style better.

image
image
image


I think it's ready.

image

An information panel will show up when clicking the packages in the explorer.

image

@antfu antfu marked this pull request as ready for review January 15, 2020 07:38
static/ide.html Outdated Show resolved Hide resolved
@LingDong- LingDong- merged commit 7ddf7ac into wenyan-lang:master Jan 15, 2020
@LingDong-
Copy link
Member

Awesome! Maybe in the future when there are way too many 文淵閣 packages we need to hide them better in the GUI, but currently there are not enough so it makes sense to advertise them like right now, so great!
Thanks for the good work!

@antfu
Copy link
Member Author

antfu commented Jan 15, 2020

Yes indeed. With the packages grows, we may consider adding a packages explorer with searching. Users can add packages they want to the explorer. And yes, that's for later. 👍

@antfu antfu mentioned this pull request Jan 17, 2020
LingDong- added a commit that referenced this pull request Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants