Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

werf dismiss --with-namespace hangs when there is a PVC in this namespace #99

Open
distorhead opened this issue Sep 30, 2021 · 2 comments

Comments

@distorhead
Copy link
Member

No description provided.

@distorhead
Copy link
Member Author

Update. This is probably not related to PVC.

Potential race-condition is here: https://github.com/werf/kubedog/blob/main/pkg/trackers/elimination/elimination.go#L136

  • Check object exists using objects list.
  • Then run informer.

If object was found in objects list, then deleted, then we run informer, then this informer may not receive object "deleted" signal which would result in hanging elimination process.

@ilya-lesikov
Copy link
Member

In werf v2 we have very different logic for tracking resource deletions, so there is probably no such issue. But werf dismiss is still using the old deployment/tracking engine. When we migrate werf dismiss to Nelm (#6155) it surely should be solved.

@ilya-lesikov ilya-lesikov mentioned this issue Jul 24, 2024
1 task
@ilya-lesikov ilya-lesikov transferred this issue from werf/werf Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants