feat: Fix and improve state evaluation for "disk status" check #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
commented
Mar 14, 2022
Comment on lines
-124
to
-125
| if critical and critical < int(disk_temp) or int(disk_status_nr) == (4 or 5): | ||
| state = 'CRITICAL' |
Beforehand, the code would only detect `SystemPartitionFailed`, while `Crashed` would have been missed. After fixing that, the code has been expanded to offer a more general approach for converging sensor states of *multiple* items (here: disks) into a single outcome state. Now, the state evaluation flow is more linear and can easily be reused for all other checks involving multiple items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Frederic,
it's me again ;]. While looking at the code in more detail, we discovered a minor flaw and thought it would be a good idea to submit a patch. Beforehand, the code would only detect disk status
SystemPartitionFailed, whileCrashedwould have been missed.After fixing that, the code has been expanded to offer a more general approach for converging sensor states of multiple items (here: disks) into a single outcome state. Now, the state evaluation flow is more linear and can easily be reused for all other checks involving multiple items. We hope you like it.
With kind regards,
Andreas.