New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disk state evaluation and add the shebang line #31
Conversation
Ok, I've checked it, and I think this a bug. To append a entire String to an array you should use But I like to know if this works for @amotl |
I can confirm this BUG. Please use append and add a python3 shebang. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - @amotl pls share your thoughts on this anyways (going to merge in the next days if no response)
@all-contributors add @Doomas for code |
I've put up a pull request to add @Doomas! 🎉 |
@all-contributors please add @Kraeutergarten for User Testing |
I've put up a pull request to add @Kraeutergarten! 🎉 |
Hi there, it definitively looks like that I made a mistake here. Apologies. Thank you very much for discovering and fixing this, @Doomas! @wernerfred: I think it is ready to be merged. Go ahead! With kind regards, |
Hi
Disk state fix:
adding the disk states with
+=
results in an Array of single letters. Therefore the final disk state was in every case "UNKOWN". Withstates.append()
it works as intended.Shebang:
The script was not automatically execute on my servers without the shebang
Regards Thomas