Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date (month/day/year?) to the episode's sidebar #449

Closed
waldothedeveloper opened this issue Jan 7, 2020 · 7 comments
Closed

Add date (month/day/year?) to the episode's sidebar #449

waldothedeveloper opened this issue Jan 7, 2020 · 7 comments

Comments

@waldothedeveloper
Copy link
Contributor

Hey guys happy 2020!

This is a suggestion.
I think it would be a good idea to add the dates of the episodes below the Episode titles (marked in red in the screenshot).
I see that when you click on each episode you can see the date on the upper right (also marked in red in the screenshot) but it takes that one extra click -in my modest opinion- so I think it should be beneficial to have it there as well if you want to look at the dates based on the Episode's titles.
I love the show btw!

Screen Shot 2020-01-06 at 9 32 51 PM

@wesbos
Copy link
Collaborator

wesbos commented Jan 22, 2020

Yeah this is a good idea. Who wants to implement it?

@waldothedeveloper
Copy link
Contributor Author

waldothedeveloper commented Jan 22, 2020

I can send a PR if that's ok :)

@waldothedeveloper
Copy link
Contributor Author

ok @wesbos and/or @stolinski
Let me know if you guys like it like this or if you want a different color accent, some little extra padding, or anything else, if not I'll submit the PR.
I used the "newgrey" from your _show.styl file.

image

image

@wesbos
Copy link
Collaborator

wesbos commented Jan 23, 2020

looks great! please send a PR

@shayaulman
Copy link
Contributor

Little Improvement

Hey @waldothedeveloper, what do you say to this little change?

  1. I changed that the episode number and the date should be on the same line.
  2. The date - as it is additional info - has a little bit a lighter shade (gray2).

Screen Shot 2020-02-06 at 13 26 55

Why I think it's better?

  1. The 2 pieces of info are on the same line.
  2. This expands less the tab vertically

What do you think? please let me know...
Thanks!

@wesbos
Copy link
Collaborator

wesbos commented Feb 6, 2020

I like it! Send a PR?

@waldothedeveloper
Copy link
Contributor Author

Wow, that looks very cool now!
@shayaulman with two more tweaks we have a startup idea LOL...
Thank you guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants