Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imprv: Add send email to user feat to /reset-password endpoint v5 #7382

Merged
merged 5 commits into from
Feb 17, 2023

Conversation

jam411
Copy link
Contributor

@jam411 jam411 commented Feb 13, 2023

task: https://redmine.weseek.co.jp/issues/114407

関連PR

#7356 -> 説明: v6 master へマージ済み
#7404 -> 説明: このPR #7382 と動作確認を経て v6 への追加アップデート PR

Screenshot

image

image

image

@jam411 jam411 changed the title imprv: Add send email to user feat to reset-password endpoint imprv: Add send email to user feat to /reset-password endpoint Feb 13, 2023
@jam411 jam411 temporarily deployed to VRT February 13, 2023 08:42 — with GitHub Actions Inactive
@jam411 jam411 changed the title imprv: Add send email to user feat to /reset-password endpoint imprv: Add send email to user feat to /reset-password endpoint v5 Feb 13, 2023
Comment on lines -834 to -842
* content:
* application/json:
* schema:
* properties:
* newPassword:
* type: string
* user:
* type: object
* description: Target user
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

200の場合 {} を返すので content 部分を削除
/smtp-test などを参考

@@ -58,13 +56,10 @@ class PasswordResetModal extends React.Component {

return (
<>
<p className="alert alert-danger">{t('admin:user_management.reset_password_modal.password_reset_message')}</p>
<p className="text-danger">{t('admin:user_management.reset_password_modal.password_reset_message')}</p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text-danger に統一

@jam411 jam411 temporarily deployed to VRT February 17, 2023 01:29 — with GitHub Actions Inactive
@reg-suit
Copy link

reg-suit bot commented Feb 17, 2023

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@jam411 jam411 self-assigned this Feb 17, 2023
@yuki-takei yuki-takei merged commit 5957679 into dev/5.1.x Feb 17, 2023
@yuki-takei yuki-takei deleted the imprv/114407-reset-password-endpoint branch February 17, 2023 06:52
@miya miya mentioned this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants