Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imprv: Admin user can use reset-password without email settings #7650

Conversation

jam411
Copy link
Contributor

@jam411 jam411 commented May 15, 2023

task: https://redmine.weseek.co.jp/issues/121726

  • メール設定に依存せずに管理者がユーザーのパスワードをリセットできる

やったこと

Screenshot

image

関連PR

後続タスク

@jam411 jam411 temporarily deployed to VRT May 15, 2023 03:32 — with GitHub Actions Inactive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

後続タスクで使うので残す

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました

@@ -58,6 +60,9 @@ class PasswordResetModal extends React.Component {
<p>
{t('user_management.reset_password_modal.target_user')}: <code>{userForPasswordResetModal.email}</code>
</p>
<p>
{t('user_management.reset_password_modal.new_password')}: <code>{this.state.temporaryPassword}</code>
</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

欲を言えば collapse で隠したい

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

後続ストーリーに記載しました。

@jam411 jam411 temporarily deployed to VRT May 16, 2023 02:33 — with GitHub Actions Inactive
@jam411 jam411 temporarily deployed to VRT May 16, 2023 02:58 — with GitHub Actions Inactive
@jam411 jam411 temporarily deployed to VRT May 16, 2023 03:08 — with GitHub Actions Inactive
@reg-suit
Copy link

reg-suit bot commented May 16, 2023

reg-suit detected visual differences.

Check this report, and review them.

⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪⚪

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@jam411 jam411 merged commit 96006fe into master May 16, 2023
23 checks passed
@jam411 jam411 deleted the imprv/119788-121726-admin-can-use-reset-password-without-email-setting branch May 16, 2023 03:12
@github-actions github-actions bot mentioned this pull request May 16, 2023
@yuki-takei yuki-takei mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants