fix: Deleted descendant pages do not appear in search results #7583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miya
commented
Apr 19, 2023
| @@ -1468,6 +1468,9 @@ class PageService { | |||
|
|
|||
| throw err; | |||
| } | |||
| finally { | |||
| this.pageEvent.emit('syncDescendantsUpdate', deletedPage, user); | |||
| } | |||
There was a problem hiding this comment.
バグの原因
ES 上から子孫ページを消したままで、/trash に移動したページデータを ES に保存していなかったことが原因
growi/apps/app/src/server/service/page.ts
Line 1621 in aafc596
|
reg-suit detected visual differences. Check this report, and review them. 🔴🔴🔴🔴🔴 🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
yuki-takei
deleted the
fix/120600-deleted-descendant-pages-do-not-appear-in-search-results
branch
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
#120476 ゴミ箱に出し入れした際の全文検索のバグを修正する
└ #120600 修正 (問題1)