Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Deleted descendant pages do not appear in search results #7583

Merged
merged 1 commit into from
Apr 19, 2023
Merged

fix: Deleted descendant pages do not appear in search results #7583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/app/src/server/service/page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1468,6 +1468,9 @@ class PageService {

throw err;
}
finally {
this.pageEvent.emit('syncDescendantsUpdate', deletedPage, user);
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

バグの原因

ES 上から子孫ページを消したままで、/trash に移動したページデータを ES に保存していなかったことが原因

growi/apps/app/src/server/service/page.ts

Line 1621 in aafc596

this.pageEvent.emit('syncDescendantsDelete', pages, user);

})();
}
else {
Expand Down