guard against invalid [scenario]playing_team

wesnoth · Mar 16, 2020 · 0cdb3e5 · 0cdb3e5
1 parent a3859e4
commit 0cdb3e5
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/game_state.cpp b/src/game_state.cpp
@@ -191,6 +191,11 @@ void game_state::init(const config& level, play_controller & pc)
 	LOG_NG << "initialized teams... "    << (SDL_GetTicks() - pc.ticks()) << std::endl;
 
 	board_.teams_.resize(level.child_count("side"));
+	if (player_number_ > static_cast<int>(board_.teams_.size())) {
+		ERR_NG << "invalid player number " <<  player_number_ << " #sides=" << board_.teams_.size() << "\n";
+		player_number_ = 1;
+		// in case there are no teams, using player_number_ migh still cause problems later.
+	}
 
 	std::vector<team_builder_ptr> team_builders;