Skip to content

Commit

Permalink
gui/mp: Fix two strings not being translated in the UI
Browse files Browse the repository at this point in the history
This is caused by a broken assumption on wmlxgettext's part. Because the
files did not have a textdomain directive anywhere, the translatable
strings in them were assigned to the wesnoth textdomain. The game engine
seems to have a different idea though, and includes them in an
unidentified textdomain that may or may not be wesnoth-lib, as per the
last #textdomain directive seen in the combined WML for the
data/gui/macros directory substitution.

This merits further examination of the preprocessor's code (and
wmlxgettext's logic), but for now this is a simple patch that fixes the
issue without breaking the string freeze or introducing any potential
regressions.

This fixes two particular strings mentioned in issue #2709:

 * "There are no custom options available for the selected era, game, or modification."
 * "Connected Players"

Vultraz made a similar fix in commit
8d1ec62 in master, but it breaks the
string freeze by virtue of moving the strings across textdomains.

[ci skip]
  • Loading branch information
irydacea committed Mar 23, 2018
1 parent 26b3274 commit 15db518
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions data/gui/macros/custom_options_tree.cfg
@@ -1,3 +1,4 @@
#textdomain wesnoth
#
# Not a dialog, but a common portion of dialog layout used in at least two dialogs
#
Expand Down
1 change: 1 addition & 0 deletions data/gui/macros/player_list_panel.cfg
@@ -1,3 +1,4 @@
#textdomain wesnoth
#
# Common player list layout used in MP Staging and MP Join Game
#
Expand Down

0 comments on commit 15db518

Please sign in to comment.