Skip to content

Commit

Permalink
Travis: Consider non-virtual destructors an error in base classes
Browse files Browse the repository at this point in the history
This also fixes another case where one was missing.
  • Loading branch information
CelticMinstrel committed Apr 8, 2017
1 parent d9f771b commit 2eed698
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion SConstruct
Expand Up @@ -496,7 +496,7 @@ for env in [test_env, client_env, env]:

if "clang" in env["CXX"]:
# Silence warnings about unused -I options and unknown warning switches.
env.AppendUnique(CCFLAGS = Split("-Qunused-arguments -Wno-unknown-warning-option"))
env.AppendUnique(CCFLAGS = Split("-Qunused-arguments -Wno-unknown-warning-option -Werror=non-virtual-dtor"))

if "suncc" in env["TOOLS"]:
env["OPT_FLAGS"] = "-g0"
Expand Down
2 changes: 2 additions & 0 deletions src/units/frame_private.hpp
Expand Up @@ -66,6 +66,8 @@ class progressive_base
return data_;
}

virtual ~progressive_base() {}

private:
data_t data_;
std::string input_;
Expand Down

0 comments on commit 2eed698

Please sign in to comment.