Clarify implicit cast to boolean

Should not really assume that SDL_JoystickGetAttached() will return a non-zero value as 'true'. Some functions return 0 as 'success'.
wesnoth · Sep 25, 2015 · 3546738 · 3546738
1 parent f890564
commit 3546738
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/joystick.cpp b/src/joystick.cpp
@@ -41,7 +41,7 @@ static bool attached(
 		  const std::vector<SDL_Joystick*>& joysticks
 		, const size_t index)
 {
-	return SDL_JoystickGetAttached(joysticks[index]);
+	return SDL_JoystickGetAttached(joysticks[index]) == SDL_TRUE;
 }
 
 static const char* name(