Skip to content

Commit

Permalink
play_controller::check_victory(): use underscore in event name
Browse files Browse the repository at this point in the history
Semantically this doesn't change anything because spaces in event names are
automatically replaced with underscores.

I just spent a considerable amount of time searching for code that fires
the enemies_defeated event, only to find that it's called
"enemies defeated", with a space, at the call site. Let's use the
underscored name everywhere to make the function easier to find.
  • Loading branch information
jyrkive committed Aug 4, 2016
1 parent 531b913 commit 3cbf249
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/play_controller.cpp
Expand Up @@ -949,7 +949,7 @@ void play_controller::check_victory()
}

if (found_player || found_network_player) {
pump().fire("enemies defeated");
pump().fire("enemies_defeated");
if (is_regular_game_end()) {
return;
}
Expand Down

0 comments on commit 3cbf249

Please sign in to comment.