Properly handle an error condition

Found by coverity
wesnoth · Jun 10, 2016 · 433a3ad · 433a3ad
1 parent 54c03ea
commit 433a3ad
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/actions/undo.cpp b/src/actions/undo.cpp
@@ -321,6 +321,11 @@ void undo_list::read(const config & cfg)
 			undo_action_base * action = create_action(child);
 			if ( undo_action* undoable_action = dynamic_cast<undo_action*>(action)) {
 				redos_.push_back(undoable_action);
+			} else {
+				delete action;
+				ERR_NG << "Error: redo contained action that is not undoable" << std::endl;
+				ERR_NG << "config was: " << child.debug() << std::endl;
+				ERR_NG << "Skipping this redo action..." << std::endl;
 			}
 		} catch (bad_lexical_cast &) {
 			ERR_NG << "Error when parsing redo list from config: bad lexical cast." << std::endl;