Skip to content

Commit

Permalink
Fix build with TDM-GCC
Browse files Browse the repository at this point in the history
@newfrenchy83 said that the build is failing:
37225d2#commitcomment-25629052

It looks like TDM-GCC uses Windows XP development headers, unfortunately.
However, the problem is easy to work around by simply #defining the missing
value ourselves. We should consider dropping TDM-GCC support after the 1.14
release, though.
  • Loading branch information
jyrkive committed Nov 20, 2017
1 parent c8b3785 commit 5535b36
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/filesystem_boost.cpp
Expand Up @@ -38,6 +38,10 @@ using boost::uintmax_t;
#include <windows.h>
#include <shlobj.h>
#include <shlwapi.h>

// Work around TDM-GCC not #defining this according to @newfrenchy83.
#define VOLUME_NAME_NONE 0x4

#endif /* !_WIN32 */

#include "config.hpp"
Expand Down

5 comments on commit 5535b36

@newfrenchy83
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

droping tdm-gcc, yes but what in replace mingw by numen or mingw64

@GregoryLundberg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest MinGW-64

TDM-gcc is way out-of-date and appears no longer maintained. Don't know 'numen'. As far as I can tell, MinGW-64 is still actively maintained.

@GregoryLundberg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: What's wrong with using Microsoft Build Tools?

If you're on Windows 7, or later, on a 64-bit machine, you can set up Build Tools, Git, and Visual Studio Code as a fairly decent build system. It's not quite a full IDE but more than good enough for maintaining the C++, compiling and debugging, and working with Git. About the only issue with doing a full-native build is the 'external' kit does not include the executables to rebuild the translations.

@newfrenchy83
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's nuwen.net not numen. sorry

@GregoryLundberg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see it's currently maintained.

Please sign in to comment.