SotA: Don't use split on translatable strings

It should be easier for the translators if each string is a separate translatable string. That way, they don't even need to worry about taking care with commas.
wesnoth · Oct 4, 2020 · 6016b81 · 6016b81
1 parent 105a551
commit 6016b81
Showing 1 changed file with 88 additions and 72 deletions.
diff --git a/data/campaigns/Secrets_of_the_Ancients/utils/zombie-utils.cfg b/data/campaigns/Secrets_of_the_Ancients/utils/zombie-utils.cfg
@@ -13,81 +13,97 @@
 #define ZOMBIE_INIT
     [event]
         name=prestart
+        #wmllint: markcheck off
+        # sota_variation will be used in the zombie recruit dialog
         [set_variables]
             name=zombies
-            [split]
-                list="SotA Flying Corpse_Bat,
-                SotA Walking Corpse_Rat,
-                SotA Walking Corpse_Wolf,
-                SotA Walking Corpse_Human,
-                SotA Walking Corpse_Mounted,
-                SotA Walking Corpse_Wolf Rider,
-                SotA Swimming Corpse,
-                SotA Walking Corpse_Saurian,
-                SotA Walking Corpse_Wose,
-                SotA Walking Corpse_Goblin,
-                SotA Flying Corpse_Gryphon,
-                SotA Walking Corpse_Spider,
-                SotA Walking Corpse_Troll,
-                SotA Walking Corpse_Dwarf"
-                key=type
-                separator=","
-            [/split]
-        [/set_variables]
-        # This string will be used in the zombie recruit dialog box.
-        [set_variables]
-            name=zombies
-            mode=merge
-            [split]
-                list= _ "(Bat),
-                (Rat),
-                (Wolf),
-                (Human),
-                (Mounted),
-                (Wolf Rider),,
-                (Saurian),
-                (Wose),
-                (Goblin),
-                (Gryphon),
-                (Spider),
-                (Troll),
-                (Dwarf)" # po: The extra comma after (Wolf Rider) is for the swimming corpse. Since there is only one of those, it would be redundant to label it in English. You can add (Swimmer) before the second comma if it makes more sense in your language to do so. Be careful not to delete any commas!
-                key=sota_variation
-                separator=","
-            [/split]
-        [/set_variables]
-        [set_variables]
-            name=zombies
-            mode=merge
-            [split]
-                list= _ "You can now raise bat corpses!,
-                You can now raise rat corpses!,
-                You can now raise wolf corpses!,
-                You can now raise human corpses!,
-                You can now raise mounted corpses!,
-                You can now raise wolf rider corpses!,
-                You can now raise swimming corpses!,
-                You can now raise saurian corpses!,
-                You can now raise wose corpses!,
-                You can now raise goblin corpses!,
-                You can now raise gryphon corpses!,
-                You can now raise spider corpses!,
-                You can now raise troll corpses!,
-                You can now raise dwarf corpses!" # po: Be careful not to delete any commas!
-                key=allow_recruit_message
-                separator=","
-            [/split]
-        [/set_variables]
-        [set_variables]
-            name=zombies
-            mode=merge
-            [split]
-                # The player starts out with no zombies available.
-                list="no,no,no,no,no,no,no,no,no,no,no,no,no,no"
-                key=allow_recruit
-                separator=","
-            [/split]
+            [value]
+                type=SotA Flying Corpse_Bat
+                sota_variation= _ "(Bat)"
+                allow_recruit_message= _ "You can now raise bat corpses!"
+                allow_recruit=no
+            [/value]
+            [value]
+                type=SotA Walking Corpse_Rat
+                sota_variation= _ "(Rat)"
+                allow_recruit_message= _ "You can now raise rat corpses!"
+                allow_recruit=no
+            [/value]
+            [value]
+                type=SotA Walking Corpse_Wolf
+                sota_variation= _ "(Wolf)"
+                allow_recruit_message= _ "You can now raise wolf corpses!"
+                allow_recruit=no
+            [/value]
+            [value]
+                type=SotA Walking Corpse_Human
+                sota_variation= _ "(Human)"
+                allow_recruit_message= _ "You can now raise human corpses!"
+                allow_recruit=no
+            [/value]
+            [value]
+                type=SotA Walking Corpse_Mounted
+                sota_variation= _ "(Mounted)"
+                allow_recruit_message= _ "You can now raise mounted corpses!"
+                allow_recruit=no
+            [/value]
+            [value]
+                type=SotA Walking Corpse_Wolf Rider
+                sota_variation= _ "(Wolf Rider)"
+                allow_recruit_message= _ "You can now raise wolf rider corpses!"
+                allow_recruit=no
+            [/value]
+            [value]
+                type=SotA Swimming Corpse
+                # po: The ^ at the end means that this string is not used in English. Since there is only one swimmer corpse, it would be redundant to label it in English. You may translate this string (without the ^) if it makes more sense in your language to do so.
+                sota_variation= _ "(Swimmer)^"
+                allow_recruit_message= _ "You can now raise swimming corpses!"
+                allow_recruit=no
+            [/value]
+            [value]
+                type=SotA Walking Corpse_Saurian
+                sota_variation= _ "(Saurian)"
+                allow_recruit_message= _ "You can now raise saurian corpses!"
+                allow_recruit=no
+            [/value]
+            [value]
+                type=SotA Walking Corpse_Wose
+                sota_variation= _ "(Wose)"
+                allow_recruit_message= _ "You can now raise wose corpses!"
+                allow_recruit=no
+            [/value]
+            [value]
+                type=SotA Walking Corpse_Goblin
+                sota_variation= _ "(Goblin)"
+                allow_recruit_message= _ "You can now raise goblin corpses!"
+                allow_recruit=no
+            [/value]
+            [value]
+                type=SotA Flying Corpse_Gryphon
+                sota_variation= _ "(Gryphon)"
+                allow_recruit_message= _ "You can now raise gryphon corpses!"
+                allow_recruit=no
+            [/value]
+            [value]
+                type=SotA Walking Corpse_Spider
+                sota_variation= _ "(Spider)"
+                allow_recruit_message= _ "You can now raise spider corpses!"
+                allow_recruit=no
+            [/value]
+            [value]
+                type=SotA Walking Corpse_Troll
+                sota_variation= _ "(Troll)"
+                allow_recruit_message= _ "You can now raise troll corpses!"
+                allow_recruit=no
+            [/value]
+            [value]
+                type=SotA Walking Corpse_Dwarf
+                sota_variation= _ "(Dwarf)"
+                allow_recruit_message= _ "You can now raise dwarf corpses!"
+                allow_recruit=no
+            [/value]
         [/set_variables]
+        #wmllint: markcheck on
     [/event]
 #enddef