Skip to content

Commit

Permalink
Prevent deprecation message details from being on a separate line.
Browse files Browse the repository at this point in the history
The log handler does some kind of per-line sorting of these, so a single deprecation warning ends up with the detail line first and the message line second (line order reversed). When there are multiple deprecation messages, their detail lines and message lines get jumbled together.  This seems to be tied together with how it detects repeated instances of the exact same error/warning, so putting both the message and the detail on the same line is much simpler than tinkering with that.
  • Loading branch information
Pentarctagon committed Mar 31, 2021
1 parent 8529385 commit 690e8f0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/deprecation.cpp
Expand Up @@ -71,7 +71,7 @@ std::string deprecated_message(
}

if(!detail.empty()) {
message += "\n ";
message += "; ";
message += detail;
}

Expand Down

0 comments on commit 690e8f0

Please sign in to comment.