Remove the unnecessary function modifiers

wesnoth · Oct 15, 2020 · 6df3f92 · 6df3f92
1 parent 6c055a9
commit 6df3f92
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/addon/client.cpp b/src/addon/client.cpp
@@ -283,7 +283,7 @@ bool addons_client::download_addon(config& archive_cfg, const std::string& id, c
 	return !this->update_last_error(archive_cfg);
 }
 
-static inline std::string write_info_contents(const addon_info& info)
+static std::string write_info_contents(const addon_info& info)
 {
 	LOG_ADDONS << "generating version info for add-on '" << info.id << "'\n";
 

diff --git a/src/addon/validation.cpp b/src/addon/validation.cpp
@@ -307,12 +307,12 @@ std::string unencode_binary(const std::string& str)
 	return res;
 }
 
-static const std::string file_hash_raw(const config& file)
+static std::string file_hash_raw(const config& file)
 {
 	return utils::md5(file["contents"].str()).base64_digest();
 }
 
-const std::string file_hash(const config& file)
+std::string file_hash(const config& file)
 {
 	std::string hash = file["hash"].str();
 	if(hash.empty()) {

diff --git a/src/addon/validation.hpp b/src/addon/validation.hpp
@@ -97,7 +97,7 @@ std::string encode_binary(const std::string& str);
 std::string unencode_binary(const std::string& str);
 bool needs_escaping(char c);
 
-const std::string file_hash(const config& file);
+std::string file_hash(const config& file);
 bool comp_file_hash(const config& file_a, const config& file_b);
 void write_hashlist(config& hashlist, const config& data);
 bool contains_hashlist(const config& from, const config& to);