Skip to content

Commit

Permalink
log/windows: Don't call logging facilities during static var destruction
Browse files Browse the repository at this point in the history
This is UB and a sure recipe for disaster if log.o's variables are
destructed first. The message is superfluous and not actually intended
to be displayed in normal use (hence debug level), so let's just not
poke dead men walking.
  • Loading branch information
irydacea committed Mar 4, 2016
1 parent fab6633 commit 726f4b4
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/log_windows.cpp
Expand Up @@ -316,7 +316,6 @@ log_file_manager::~log_file_manager()
return;
}

DBG_LS << "Closing log file...\n";
fclose(stdout);
fclose(stderr);
}
Expand Down

0 comments on commit 726f4b4

Please sign in to comment.