2x change from return by copy to return by reference on const strings.

wesnoth · Jun 7, 2014 · 8750dec · 8750dec
1 parent a25ff8d
commit 8750dec
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/hotkey/hotkey_command.cpp b/src/hotkey/hotkey_command.cpp
@@ -455,12 +455,12 @@ void delete_all_wml_hotkeys()
 	}
 }
 
-const std::string get_description(const std::string& command)
+const std::string& get_description(const std::string& command)
 {
 	return get_hotkey_command(command).description;
 }
 
-const std::string get_tooltip(const std::string& command)
+const std::string& get_tooltip(const std::string& command)
 {
 	// the null hotkey_command has the "" tooltip
 	return get_hotkey_command(command).tooltip;

diff --git a/src/hotkey/hotkey_command.hpp b/src/hotkey/hotkey_command.hpp
@@ -262,8 +262,8 @@ void delete_all_wml_hotkeys();
 ///removes a wml hotkey with the given id, returns true if the deletion was successful
 bool remove_wml_hotkey(const std::string& id);
 
-const std::string get_description(const std::string& command);
-const std::string get_tooltip(const std::string& command);
+const std::string& get_description(const std::string& command);
+const std::string& get_tooltip(const std::string& command);
 
 void init_hotkey_commands();