Skip to content

Commit

Permalink
campaignd: Don't use GUI1 markup in [upload] response
Browse files Browse the repository at this point in the history
Wesnoth 1.7.x and later use a GUI2 code path to display the [upload]
response message, which means GUI1 markup won't work with it. They do
not enable Pango markup either, and in any case, formatting messages
properly should be the client's responsibility, not the server's.

Perhaps later we should allow including a secondary message in the
response or something like that.

(Backported 610070e from master.)
  • Loading branch information
irydacea committed Oct 11, 2014
1 parent 69520c4 commit 9e1d1be
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/campaign_server/campaign_server.cpp
Expand Up @@ -542,7 +542,7 @@ void server::handle_upload(const server::request& req)
std::string message = "Add-on accepted.";

if(!version_info(upload["version"]).good()) {
message += "\n<255,255,0>Note: The version you specified is invalid. This add-on will be ignored for automatic update checks.";
message += "\n\nNote: The version you specified is invalid. This add-on will be ignored for automatic update checks.";
}

if(campaign == NULL) {
Expand Down

0 comments on commit 9e1d1be

Please sign in to comment.