Codacy: Error-prone Code

Member variable 'version_info::special_separator_' is not initialized in the constructor.
wesnoth · Oct 26, 2018 · aa28426 · aa28426 · jyrkive · Oct 27, 2018
1 parent 6a7abea
commit aa28426
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/game_version.cpp b/src/game_version.cpp
@@ -27,6 +27,11 @@ version_info::version_info()
 {
 }
 
+version_info::version_info(const char* str)
+	: version_info(std::string(str))
+{
+}
+
 version_info::version_info(unsigned int major, unsigned int minor, unsigned int revision_level,
                            char special_separator, const std::string& special)
 	: nums_(3,0), special_(special), special_separator_(special_separator)

diff --git a/src/game_version.hpp b/src/game_version.hpp
@@ -45,7 +45,7 @@ class version_info
 public:
 	version_info();                    /**< Default constructor. */
 	version_info(const std::string&);  /**< String constructor. */
-	version_info(const char* str) : version_info(std::string(str)) {}
+	version_info(const char* str);
 
 	/** Simple list constructor. */
 	version_info(unsigned int major, unsigned int minor, unsigned int revision_level,